name defaults to kernelName when undefined

[stevejpurves]

Following the issue here #349 and recent discussion and changes here executablebooks/sphinx-thebe#60

We need to note that thebe-core has reverted to using the jupyterlab session interface via the SessionManager. So both name and kernelName are possible parameters. IN fact in the scenario with a named session that used the non default kernel, the kernelName is needed to select the appropriate kernelSpec to use.

With that in mind, an updated proposal is:

• Add some logic in our code to use kernelName as name if a name field is not defined, to maintain backwards compatibility in both 0.8.x and 0.9.x release branches -- this is in line with the original suggesting in New JupyterLab API for spawning kernels has a different config option name for which kernel to spawn #349

TODO:

• make changes on main for 0.9.x
• make changes on v0.8.x branch

[stevejpurves]

ok this change is made on the main branch, and we want to move forward I suggest we close this issue and not go back and forth any more on the 0.8.2 branch. See #677
Once 0.9.0 is out we can update sphinx-thebe and settle this.