fix/tolerant providers #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stevejpurves
force-pushed
the
fix/tolerant-providers
branch
from
c0f3b2a
to
1b9f19d
Compare
* 📡 add check call for user server * 👮🏻 prevent reconnect for existing server * 📕 changeset
stevejpurves
added a commit
that referenced
this pull request
Sep 6, 2023
* add binder urls * server holds url set for binder * user server url has meaning outside of binder * fix/tolerant providers (#683) * 🔧 use correct binder repo url * 🫴🏼 hooks no longer throw on undefined contexts * 📕 changeset * allow custom repoproviderspecs to be added to react server provider * 🥁don't provide np-ops * 🙅🏽 throw exception for malformed RepoProviderSpec * fix/server blatting (#685) * 📡 add check call for user server * 👮🏻 prevent reconnect for existing server * 📕 changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, attempting to use provider hooks such as
useThebeServerin a react application meant that the respective provider always has to be rendered higher in the component tree. This meant these could not be conditionally rendered based on site settings and instead an exception was thrown.hooks no longer throw but return empty or uninitialised objects instead, this allows for much more flexibility in a consuming application and avoid hard failures caused by exceptions which were bad for both DX and UX.