Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Italian localization #627

Merged
merged 1 commit into from Sep 19, 2021
Merged

Update Italian localization #627

merged 1 commit into from Sep 19, 2021

Conversation

kevinm6
Copy link
Contributor

@kevinm6 kevinm6 commented Sep 15, 2021

No description provided.

@exelban exelban merged commit ec5d8c9 into exelban:master Sep 19, 2021
@Angelk90
Copy link
Contributor

Hi @kevinm6 , I don't know if it's a problem but I get the following result when the battery is fully charged:
Schermata 2021-09-20 alle 21 33 27

https://github.com/exelban/stats/blob/master/Stats/Supporting%20Files/it.lproj/Localizable.strings#L236

@kevinm6
Copy link
Contributor Author

kevinm6 commented Sep 20, 2021

Hi @kevinm6 , I don't know if it's a problem but I get the following result when the battery is fully charged:

Schermata 2021-09-20 alle 21 33 27

https://github.com/exelban/stats/blob/master/Stats/Supporting%20Files/it.lproj/Localizable.strings#L236

Thank you @Angelk90 for show me the issue, I'll fix it soon with just “Carica” because the lenght of the text field is not enough for the full translation.

@Angelk90
Copy link
Contributor

@kevinm6 : I guess it cuts the text, right?

@kevinm6
Copy link
Contributor Author

kevinm6 commented Sep 20, 2021

Yes exactly.
I’m doing it right now, then we just have to wait @exelban to merge the fix.

@Angelk90
Copy link
Contributor

Angelk90 commented Sep 20, 2021

@kevinm6 :
I also point out this:
https://github.com/exelban/stats/blob/master/Stats/Supporting%20Files/it.lproj/Localizable.strings#L119

Schermata 2021-09-20 alle 22 25 48

Then I noticed that texts like these are not translated:

Disabled:
Schermata 2021-09-20 alle 22 12 14

Fan #Number:
Schermata 2021-09-20 alle 22 16 48

gmcinalli pushed a commit to gmcinalli/stats that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants