Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base.css on preview mode #156

Closed
antton opened this issue Mar 3, 2017 · 4 comments
Closed

base.css on preview mode #156

antton opened this issue Mar 3, 2017 · 4 comments
Assignees
Labels

Comments

@antton
Copy link

antton commented Mar 3, 2017

Morning,

Why everytime I try to check my content via preview mode the only css files used from my theme are nav.css and content.css?

The base.css used by the preview mode is from the styles root folder.

I think it should take the base.css file from the active theme folder.

Cheers!

@ignaciogros
Copy link
Collaborator

ignaciogros commented Mar 3, 2017

Thanks, @antton.

base.css will include the required CSS code. It changes from version to version. That's why we recommend to use eXe's instead of the Style's.

But it was as you say before.

@JuanCasanovaSdweb:

See getFilesCSSToMinify in common.py. It overwrites the Style's base.css file. It's not what's recommended, but if the Style has its own base.css file, it should be used instead of eXe's. No compression is needed in that case.

As you'll see, that's how it works inside eXe (add a base.css to any Style to see it).

@JuanCasanovaSdweb
Copy link
Contributor

I kept the compression on this case, I think it makes more sense to compress the file even if it is not the one that comes with eXe.

@ignaciogros: Reopen this issue if you really think we shouldn't compress it.

@ignaciogros
Copy link
Collaborator

It's just because we don't know what's in that file, and the compression might fail, but if you think that that can't happen it's OK to compress it.

Thanks.

@antton
Copy link
Author

antton commented Mar 3, 2017

Even minifying the base.css we can still check inside what it have. I think we should let it compress IMHO.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants