Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FireMonkey Fix Suggestion #21

Closed
jkour opened this issue Jan 14, 2020 · 1 comment
Closed

FireMonkey Fix Suggestion #21

jkour opened this issue Jan 14, 2020 · 1 comment

Comments

@jkour
Copy link
Contributor

jkour commented Jan 14, 2020

Hi,
I see you fixed the code in Quick.Commons to compile in other platforms.

I was thinking that this code is more suitable:

{$ELSE}
var
{$IFDEF NEXTGEN}
plogin : MarshaledAString;
{$ELSE}
plogin : PAnsiChar;
{$ENDIF}
begin
{$IFDEF POSIX}

rather than string in NEXTGEN

This is what is suggested in the docs too.

What do you think?

@exilon
Copy link
Owner

exilon commented Jan 16, 2020

You're right! Fixed now! Thanks.

@exilon exilon closed this as completed Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants