Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a more specified zone #21

Closed
vdhicts opened this issue Jan 29, 2020 · 4 comments · Fixed by #28
Closed

Create a more specified zone #21

vdhicts opened this issue Jan 29, 2020 · 4 comments · Fixed by #28
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@vdhicts
Copy link

vdhicts commented Jan 29, 2020

The purpose is to create a zone, with more specific options.

Detailed description

To create a zone, I think it would be nice to supply the Zone resource, instead of the parameters. This way it's easier to create a zone with more specific options, like a soaEditApi value.

Context

This makes it easier to create a more specific zone.

Possible implementation

$zone = new Resources\Zone();
$zone->set...();
...
$powerDns->createZoneFromResource($zone);

What needs to be done:

  1. Create a toArray function on the resource.
  2. Create a method which passes the data to $this->connector->patch()
@trizz
Copy link
Member

trizz commented Feb 19, 2020

Hi @vdhicts,

Thanks for the suggestion! I'll add it to our backlog so we can add it. I expect to release it in a new version before may, but I can't promise anything. Of course a PR is also welcome!

@trizz trizz added the enhancement Enhancement of the code, not introducing new features. label Feb 20, 2020
@vdhicts
Copy link
Author

vdhicts commented Feb 25, 2020

Thank you! If I can find some time, I will give it a shot.

@trizz
Copy link
Member

trizz commented Apr 1, 2020

@vdhicts We've just released version 2.2.0 with this feature. See the new example on how to use it.

@vdhicts
Copy link
Author

vdhicts commented Apr 1, 2020

Very nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant