Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are optional scopes supported? #3

Closed
emptyflask opened this issue Jan 11, 2021 · 3 comments
Closed

Are optional scopes supported? #3

emptyflask opened this issue Jan 11, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@emptyflask
Copy link

@marco-nicola sorry to bug you, but it seems like optional scopes are ignored -- when specifying scopes on the authorize_device request, e.g. client_id=xxxxxx&scope=write, the returned access token only includes the default scope:

{
  "access_token": "xGHWsOTDfnbkAlMpZ2im5RwrUm2kYbFfZiyj-2wlX5Y",
  "token_type": "Bearer",
  "expires_in": 7200,
  "scope": "public",
  "created_at": 1610392346
}
@marco-nicola marco-nicola self-assigned this Jan 12, 2021
@marco-nicola
Copy link
Collaborator

Hi, don't worry, on the contrary, thanks for opening this issue.

Scopes were supposed to be supported, but there's surely a bug!

I should be already on the right track for fixing it... stay tuned!

@marco-nicola
Copy link
Collaborator

Hey, that was a flagrant mistake indeed.

It should be fixed now, in version v0.2.1. It would be really cool if you can give it a try and report here whether it works, or maybe there is still something I missed.

Thanks!

@marco-nicola marco-nicola added the bug Something isn't working label Jan 13, 2021
@emptyflask
Copy link
Author

Thanks! That fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants