Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Exoplanet/Pymc3 interact with TTVFaster? #252

Closed
asmasca opened this issue Apr 5, 2022 · 3 comments
Closed

Can Exoplanet/Pymc3 interact with TTVFaster? #252

asmasca opened this issue Apr 5, 2022 · 3 comments

Comments

@asmasca
Copy link

asmasca commented Apr 5, 2022

Hi Dan, I'm Alejandro Suárez Mascareño, we spoke at the Oxford GPRV workshop.

Yesterday I started playing around with Exoplanet/Pymc3 following your recommendation. First of all I want to say I'm impressed about how efficient it is, and how convenient lots of the functions are. Thanks for pointing me here.

I tried to move a likelihood designed for Dynesty/Emcee into Exoplanet, that includes a call to the python interface of TTVFaster (1). I found out that TTVFaster really doesn't like the objects created by pymc3. Do you know if there's a way to make them interact nicely? Or an alternative that can be used?

I know I can always sample directly the times of transits (as in the tutorial), and then compute the masses later, but I wanted to sample the planetary parameters directly into the model to fit activity, transits and RV simultaneously.

(1)https://github.com/ericagol/TTVFaster/tree/master/Python

Thanks in advance

@dfm
Copy link
Member

dfm commented Apr 5, 2022

Unfortunately it wouldn't be trivial to interface TTVFaster and PyMC/exoplanet since a differentiable Theano/Aesara op would be necessary. That being said, I bet it wouldn't be too brutal to implement the TTVFaster equations directly in Theano.

@ericagol
Copy link
Collaborator

ericagol commented Apr 5, 2022

Yes, they are fairly straightforward. The most complicated part is computing the Laplace integrals.

@asmasca
Copy link
Author

asmasca commented Apr 6, 2022

Ok, that sounds like a thing I might be tempted to try. Is the python code (ttvfaster.py) fully functional? or would it be better to continue using the C version (as called by _ttvfaster.pyx).

@dfm dfm closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants