Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused variables #23

Open
0xTimepunk opened this issue Aug 17, 2023 · 0 comments
Open

remove unused variables #23

0xTimepunk opened this issue Aug 17, 2023 · 0 comments
Labels
invalid This doesn't seem right

Comments

@0xTimepunk
Copy link
Collaborator

0xTimepunk commented Aug 17, 2023

We have a couple of unused variables detected while building, as well as function which can be restricted to view

Warning (2072): Unused local variable.
   --> lib/pigeon/src/hyperlane/HyperlaneHelper.sol:159:17:
    |
159 |                 bytes32 sender = log.topics[1];
    |                 ^^^^^^^^^^^^^^

Warning (2072): Unused local variable.
   --> lib/pigeon/src/hyperlane/HyperlaneHelper.sol:161:17:
    |
161 |                 bytes32 recipient = log.topics[3];
    |                 ^^^^^^^^^^^^^^^^^

Warning (2072): Unused local variable.
   --> lib/pigeon/src/layerzero/lib/LZPacket.sol:101:9:
    |
101 |         uint256 payloadSize = realSize - nonPayloadSize;

Warning (2018): Function state mutability can be restricted to view
   --> lib/pigeon/src/celer/CelerHelper.sol:269:5:
    |
269 |     function _estimateGas(
    |     ^ (Relevant source part starts here and spans across multiple lines).
@0xTimepunk 0xTimepunk added the invalid This doesn't seem right label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant