Recursive queries produce invalid schema introspection

[smyrick]

Library Version

0.2.7

Describe the bug

There are GraphQLTypeReferences in the schema when a recursive query like NodeGraphTest is used.

To Reproduce

On the integration test NodeGraphTest, we actually have a failing schema. If you inspect the schema after build, you will notice that the type of Node.parent is GraphQLTypeReference. This should never happen as all schemas should have the full objects.

You can add the following assert to now make a failing test

assertFalse((schema.typeMap["Node"] as? GraphQLObjectType)?.getFieldDefinition("parent")?.type is GraphQLTypeReference)

Expected behavior

There are no GraphQLTypeReference in the code. This is fixed if I use graphql-java 2019-03-07T04-34-55-809a980

[smyrick]

https://spectrum.chat/graphql-java/general/next-release~54137901-d83a-4e8f-bad5-60842eabf279

[kaqqao]

For what it's worth, I think the issue can be worked around by creating a new GraphQLTypeReference each time. The bug in graphql-java v11 is that it replaces each individual instance only once.