Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configuration-properties in clients HiveConf #77

Closed
patduin opened this issue May 17, 2018 · 4 comments · Fixed by #206
Closed

Use configuration-properties in clients HiveConf #77

patduin opened this issue May 17, 2018 · 4 comments · Fixed by #206

Comments

@patduin
Copy link
Contributor

patduin commented May 17, 2018

I'd like to use the configuration-properties that I can set in the waggle-dance-server.yml in HiveConf that is used to create Thrift Clients.

Currently we use the properties only in the Handler (the server), it would be good if we can set properties and override settings used in the clients.
For instance see ThriftMetastoreClient it contains this code:
retries = HiveConf.getIntVar(conf, HiveConf.ConfVars.METASTORETHRIFTCONNECTIONRETRIES);
But there is currently no way to override this cause we create the HiveConf ourselves in CloseableThriftHiveMetastoreIfaceClientFactory. Thus that values is hardcoded to the Hive default 3.

Acceptance Criteria:

  • Use theconfiguration-properties(see WaggleDanceConfiguration class) when creating the HiveConf for the clients.
  • Documents it's use in the README (it seems to be a hidden feature now).
@courtsVII
Copy link

#90 Waggle Dance Glue PR adds this feature

@AnanaMJ
Copy link
Contributor

AnanaMJ commented Aug 9, 2019

Hey @patduin , would this look something like this? https://github.com/HotelsDotCom/waggle-dance/compare/issue-77?

@massdosage
Copy link
Contributor

@patduin is this worth keeping open? Is the above PR from @AnanaMJ something we want to merge?

@patduin
Copy link
Contributor Author

patduin commented Feb 13, 2020

maybe keep this one as it might have a fix already. We just need to check backward compatiblity/implications. etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants