Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlit materials probably shouldn't be tonemapped #37

Open
expenses opened this issue Jun 27, 2022 · 1 comment
Open

Unlit materials probably shouldn't be tonemapped #37

expenses opened this issue Jun 27, 2022 · 1 comment

Comments

@expenses
Copy link
Owner

https://gltf-viewer.donmccurdy.com/ displays the Alicia.vrm VRM sample as like this:

20220627_17h18m08s_grim

while we currently render Alicia.VRM like this:

20220627_17h18m02s_grim

This is because we're doing tonemapping for unlit materials but probably shouldn't be.

This is very solveable when doing inline tonemapping - just don't tonemap and just do the linear-to-srgb conversion instead! But when we're doing a seperate tonemapping pass it gets harder. How do we tell that a fragment should be tonemapped or not? Perhaps we could write to the alpha channel and tonemap if the alpha is 1.0 and not if it's 0.0.

@expenses
Copy link
Owner Author

I've implemented the inline tonemapping solution in this superconductor commit: 46fffce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant