Metareviews need to be fixed to work with staggered-deadline assignments

[efg]

We just made a fix to line 28 of student_task/view.html.erb to prevent reviewing from being enabled whenever an assignment is in the metareview stage. We did so with the following code:

% if @assignment.review_allowed(@reviewee_topic_id) or @assignment.metareview_allowed(nil) or @assignment.get_current_stage(@participant.topic_id) == "Complete" %>

The parameter on metareview_allowed is currently set to nil. It SHOULD be set to something like @metareviewee_topic_id, but there is no code to define @metareviewee_topic_id. If such code is added, metareviewing MAY work correctly in staggered-deadline assignments. But it would still be necessary to check to be sure that only topics that are in the metareview phase can be metareviewed, and only topics that are in the review phase can be reivewed (assuming that the assignment is set up so that metareviewing is disallowed in the review stage, and reviewing is disallowed in the metareview stage).

If, on the other hand, reviews are SUPPOSED TO be allowed during the metareview phase, the user needs to be able to do both reviews and metareviews during that phase. New code might need to be written to effect that.

[efg]

This has evidently not been addressed, because project E1708 didn't say anything about fixing metareviews. Good to aggregate this with #162, as a project to fix (manual) metareviewing.

[efg]

E1774 was merged, and that project should have addressed this issue. However, the current code permits metareviews to be performed as long as the ASSIGNMENT metareview deadline is in the future. It should only allow metatreviews to be performed fort TOPICS whose metareview deadline is in the future.

[johnbumgardner]

This issue is still present.

[johnbumgardner]

pretty low priority. only a handful of assignments use this feature.