Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expertiza only support UTF8 characters #927

Open
yangsong8 opened this issue Mar 28, 2017 · 5 comments
Open

Expertiza only support UTF8 characters #927

yangsong8 opened this issue Mar 28, 2017 · 5 comments

Comments

@yangsong8
Copy link
Contributor

In current Expertiza db, it only supports utf8 characters. If a user wants to save any non-utf8 characters, either with importing or with typing and saving, will cause system failure.

One thing we can do is to filter out the non-utf8 chars before saving, but the problems, there could be many models/fields got involved.

Another idea is, we can try to make a change on the char set of the DB. This will increase the db size.

@yangsong8 yangsong8 added the bug label Mar 28, 2017
@ferryxo ferryxo added this to the Priority 3 milestone Jun 7, 2017
@yangsong8
Copy link
Contributor Author

We are going to migrate the db to postgresql during the summer. Will revisit this issue after that.

@ferryxo
Copy link
Contributor

ferryxo commented Jun 7, 2017

maybe check if the review text is in UTF-8 before it's submitted

@efg
Copy link
Member

efg commented Jul 20, 2018

Yang says this is a problem for Chinese, who may accidentally type Chinese commas, and then their review is lost.

@johnbumgardner
Copy link
Collaborator

image

Still present

@johnbumgardner
Copy link
Collaborator

image
Here is a UTF 8 error
Despite E1846 being merged this still doesnt work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants