Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2006. Refactor tree_display_controller.rb #1698

Merged
merged 48 commits into from
Jul 31, 2020
Merged

E2006. Refactor tree_display_controller.rb #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
4593abb
Move to a more logical place instead of breaking up the gotos
Mar 15, 2020
2732cef
Compact gotos
Mar 15, 2020
917e1b3
Comment cleanup
Mar 15, 2020
0f3cda3
Assign private designation to internal methods
Mar 15, 2020
8ffa279
Remove unused function
Mar 15, 2020
1d64018
Refactor children_node_ng
Mar 14, 2020
53372d9
Remove duplicate functions created by the merge.
Mar 15, 2020
e980124
Merge branch 'beta' into refactor_children_node_ng
Mar 15, 2020
d7a364e
Refactor assumes an object with FolderNode properties is passed to ch…
Mar 15, 2020
a2e6a31
Merge branch 'refactor_children_node_ng' into beta
Mar 15, 2020
6f0ca74
Remove unused function
Mar 15, 2020
9a1d5ca
Rename children_node_2_ng to get_sub_folder_contents
Mar 15, 2020
cfd879f
Remove unused function
Mar 15, 2020
5db9d18
Update logic for ta_for_current_course?()
Ackleberry Mar 15, 2020
4032f89
Clean up spacing.
Ackleberry Mar 19, 2020
f88a582
Make sorting folders by instructor/assignments more readable.
Ackleberry Mar 19, 2020
34fec5a
Make acronyms more obvious.
Ackleberry Mar 19, 2020
867fa9d
Update 'serialize_to_json' to a better method name.
Ackleberry Mar 19, 2020
135c590
Make use of existing update_tmp_obj() method.
Ackleberry Mar 19, 2020
206775a
Remove courses_assignments_obj()
Ackleberry Mar 19, 2020
25382dd
Remove update_tmp_obj(). Its only used in one place now.
Ackleberry Mar 19, 2020
9798495
Cleanup goto functions
Mar 19, 2020
53af5ed
Comment and naming cleanup
Mar 20, 2020
7de2d24
Bug fix for when root level folder collection does not contain an 'As…
Mar 20, 2020
d7acad1
Inline function call to make json serialization more clear
Mar 20, 2020
7fc2cdb
Remove filter. Only used in the tree_display _page_header partial w…
Mar 20, 2020
75de420
RSpec updates with name changes
Mar 20, 2020
7ab79e4
Bug fix TypeError
Mar 20, 2020
fd412e5
Missing instructor ID
Mar 20, 2020
ce3b388
Handle the possiblity that instructor_id could be nil for a node.
Mar 20, 2020
2ea9a22
Add assignment_or_course_is_available?()
Ackleberry Mar 21, 2020
a9dcbe4
Remove update_is_available() and update_is_available_2() methods.
Ackleberry Mar 21, 2020
774de85
Update go_to comment.
Ackleberry Mar 21, 2020
91f62ee
Make private keyword more obvious.
Ackleberry Mar 21, 2020
d6b2125
Replace 'Course.find(@course1.id).id' with '@course1.id'
pjloheide Mar 21, 2020
81a4010
Remove unnecessary code to sort assignments by instructor and creatio…
pjloheide Mar 21, 2020
9e3f1b1
Remove TODO
Ackleberry Mar 23, 2020
730b4da
Tests are no longer used.
Ackleberry Mar 24, 2020
696b5b8
Explicitly say the course is private for readability.
Ackleberry Mar 24, 2020
d46a8c7
Update method names to not specify assignment.
Ackleberry Mar 24, 2020
b883517
Add missing method comments.
Ackleberry Mar 24, 2020
b0abf5b
Correct #list test from using NOT logic to give false positives.
Ackleberry Mar 31, 2020
aaa7bc6
Add another #list test for TA.
Ackleberry Mar 31, 2020
3681b61
Remove out of scope 'ta?' method test.
Ackleberry Mar 31, 2020
49ae61a
Remove extra line.
Ackleberry Apr 1, 2020
dcec8ad
Add set_session_last_open_tab test.
Ackleberry Apr 1, 2020
9c384ab
Merge branch 'beta' into beta
adityag3 Jul 31, 2020
022d3b5
Update tree_display_controller.rb
adityag3 Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view