Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with experiment.js #1

Open
nickyd41 opened this issue Aug 11, 2018 · 2 comments
Open

Issues with experiment.js #1

nickyd41 opened this issue Aug 11, 2018 · 2 comments

Comments

@nickyd41
Copy link

I found two issues with the experiment code:

(1) The experiment runs only 6 of the 7 delays. I fixed this by adding 1 to the delays.length loop (experiment.js, line 328). It seems to fix the problem (though I am not sure if this is the most appropriate solution).

for (var i = 0; i < (delays.length**+1**); i++) {
bickel_titrator_experiment.push(update_delay_block);

(2) There is a typo in the convertToDays function (experiment.js, line 125). It reads 60 months rather than 6 months, so the delay is not printed out in the output file.

@vsoch
Copy link
Contributor

vsoch commented Aug 11, 2018

so glad that you caught these! Would you like to do a PR to fix these issues in the code, and then have your contribution in the git history?

@vsoch
Copy link
Contributor

vsoch commented Aug 12, 2018

hey @nickyd41 I hope it's ok, I put in a PR to address the issues that you found. Would you be able to take a look? #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants