Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Umbrella issue for API error handling #164

Closed
2 tasks
barthap opened this issue Dec 16, 2020 · 4 comments
Closed
2 tasks

[eas-cli] Umbrella issue for API error handling #164

barthap opened this issue Dec 16, 2020 · 4 comments
Labels
enhancement New feature or request stale

Comments

@barthap
Copy link
Contributor

barthap commented Dec 16, 2020

Feel free to edit/update this issue.

There are cryptic error messages when API requests fail, for example:

✖ Creating @barthap10/barthap-dogfood on Expo
    HTTPError: Response code 500 (Internal Server Error)

Since we reach API in two ways, we should handle both:

We should at least display error message from www by default. Also, maybe full stacktrace should be printed when given e.g. EXPO_DEBUG env variable.

List of other related issues

@byCedric
Copy link
Member

byCedric commented Dec 16, 2020

I also want to add another use case which I ran into when working on the channel commands.

When we search for an app, it's based on user input (through project configuration). The app may or may not exist. It's a bit hard to create good feedback with this error handling kicking in with a 400 status when the app doesn't exist.

Take this query for example, just returning null for non-existing apps would be sufficient to signal there is no app with the name @bycedrictest/hue-p1 (there is one, without 1 suffix). It allows us to just check with if (app) and then log or prompt.

query {
  app {
    byFullName(fullName: "@bycedrictest/hue-p1") {
      id
      name
      fullName
    }
  }
}

@dsokal dsokal added the enhancement New feature or request label Sep 8, 2021
@senorflor
Copy link

Accidentally added this use/test case to a closed issue, so linking here to close the loop: #136 (comment)

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This issue is stale because it has been open for 30 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Apr 7, 2022
@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

4 participants