Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect google service account file in the project dir #511

Closed
dsokal opened this issue May 25, 2020 · 0 comments · Fixed by #520
Closed

Detect google service account file in the project dir #511

dsokal opened this issue May 25, 2020 · 0 comments · Fixed by #520
Assignees

Comments

@dsokal
Copy link
Contributor

dsokal commented May 25, 2020

This is a follow-up to expo/expo-cli#2069.

A comment from @brentvatne:

just an idea - an alternative might be to look in cwd for something that matches this format, or is a json file and contains "type": "service_account", and suggest that one, then only use this value as a fallback if we can't find anything.

another option (and could be done in addition to the above) would be that after the first submission of the app we save away the most recently used service account location to .expo and populate the default with that. but this may be overkill for a small thing like this, and it doesn't really help as much with the first submission

I think that I prefer the first option - we should try to find the service account file and suggest the path in the prompt.

@dsokal dsokal self-assigned this May 25, 2020
@brentvatne brentvatne changed the title [expo-cli][submission-service] detect google service account file in the project dir Detect google service account file in the project dir Jul 16, 2020
@dsokal dsokal assigned barthap and unassigned dsokal Jul 14, 2021
@dsokal dsokal transferred this issue from expo/expo-cli Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants