Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated code coverage reports for each PR #6

Closed
ide opened this issue Sep 15, 2020 · 4 comments · Fixed by #26
Closed

Automated code coverage reports for each PR #6

ide opened this issue Sep 15, 2020 · 4 comments · Fixed by #26
Assignees
Labels
enhancement New feature or request

Comments

@ide
Copy link
Member

ide commented Sep 15, 2020

Adding coverage reports is easy while a codebase is new and there isn't a lot of code to cover. It will also make it easier for code reviewers to ask authors to include tests if they haven't.

@ide ide added the enhancement New feature or request label Sep 16, 2020
@byCedric
Copy link
Member

byCedric commented Sep 19, 2020

Alright, I want to test a setup with codecov and flags. But for that, I need the repo added to codecov, but I can't seem to add a "private scope" to allow codecov access this private repo. If someone with more privileges can try that for me, that would be awesome! If you open this link, you should be able to add this repo to codecov.

I'm also open to use a different service, like coveralls or something else. Let me know if you want to do that instead.

@ide
Copy link
Member Author

ide commented Sep 20, 2020

I added eas-cli to the list of allowed repositories for Codecov.

@byCedric
Copy link
Member

Alright, thanks I activated the repo on Codecov. Now we only need to add the token, I'll ask @fson to do that because I can't access settings 😄

@ide
Copy link
Member Author

ide commented Sep 23, 2020

@byCedric You should now have access to this repo's settings.

@fson fson closed this as completed in #26 Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants