Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to UIBarButtonSystemItem Icons / Text #28

Closed
cancan101 opened this issue Nov 10, 2015 · 4 comments
Closed

Access to UIBarButtonSystemItem Icons / Text #28

cancan101 opened this issue Nov 10, 2015 · 4 comments

Comments

@cancan101
Copy link
Contributor

On IOS, the native navigator has access to the various icons and text in UIBarButtonSystemItem. These icons are occasionally updated in new versions of IOS and the text is localized.

It would be great to have access tot these with ExNavigator on IOS.

@cancan101
Copy link
Contributor Author

For example when using UIBarButtonSystemItemCancel:
image
image
and I get this for "free" without having to do the localization of strings myself.

@jadsonlourenco
Copy link

@cancan101 I agree. But, I think the EX-Navigator is for "Router/Navigator" feature for RN. You can use a package like that: https://github.com/stefalda/ReactNativeLocalization for "language feature" - that can be used on all components - and use the renderRightButton() to render the text on Topbar.

import LocalizedStrings from 'react-native-localization';
let strings = new LocalizedStrings({
  en:{
    cancel: "Cancel",
  },
  pt: {
    cancel: "Cancelar",
  }
});
// Render
renderRightButton() {
  <Text>
    {strings.cancel}
  </Text>
}

@cancan101
Copy link
Contributor Author

Sure, I was hoping to lean on the work Apple has already done to localize those strings rather than doing it myself (FWIW the linked library does look nice).

Further there is the question of getting access to the native icons. While there are packages like: https://github.com/corymsmith/react-native-icons and https://github.com/oblador/react-native-vector-icons, for consistency I would like to use the actual IOS native icons.

@ide
Copy link
Member

ide commented Nov 10, 2015

One thing we're trying to do with ExNavigator is focus on cross-platform support. So we can take inspiration from Apple's design but can't rely on calling their actual functions. For example translating Cancel -> Cancelar is something you'll have to do however you see fit for your codebase.

Likewise for the native icons we can't tell UINavigationController to display them because we're not using any complex UIKit views. My suggestion here would be to extract the iOS art assets and then display them using RN's <Image> component.

If there are generalized solutions for adding nav bar buttons that ExNavigator can help with, we can look into that.

@ide ide closed this as completed Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants