Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Title max length parameter #95

Open
fxhereng opened this issue Feb 18, 2016 · 4 comments
Open

[Feature request] Title max length parameter #95

fxhereng opened this issue Feb 18, 2016 · 4 comments

Comments

@fxhereng
Copy link

Hi,

Thanks for the great job! I would need a title length a bit longer than 18.. would it be possible to have a parameter like:

<ExNavigator
    showNavigationBar={true}
    navigationBarStyle={styles.navigationBar}
    titleStyle={styles.title}
    sceneStyle={styles.scene}
    maxTitleLength={20} //<--- new parameter
    initialRoute={initialRoute} />

to enable to have title longer than 18 caracters?

That would be great!

Thanks,

@fxhereng
Copy link
Author

Hi,

I'm trying to make a pull request with that modification but I can't push my commits in the branch I created, I'm getting this error:

remote: Permission to exponentjs/ex-navigator.git denied to fxhereng.
fatal: unable to access 'https://github.com/exponentjs/ex-navigator.git/': The requested URL returned error: 403

Could you explain to me the procedure to make a pull request?

I would appreciate,

Thanks!

@ide
Copy link
Member

ide commented Apr 28, 2016

Instead of maxTitleLength, how about a function called truncateTitle that receives the original title and is supposed to return the new one? That way you can decide how the title is shortened.

@ide
Copy link
Member

ide commented Apr 28, 2016

Read this for how to send PRs: https://help.github.com/articles/using-pull-requests/

@fxhereng
Copy link
Author

Sure, and as default parameter I can put the shortenTitle function you already have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants