-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expo-github-action/preview should support generating dev-client QR codes #214
Comments
Hi @thespacemanatee! Do you have the scheme configured in your
For example, this PR from my monorepo example repo doesn't have the But adding the |
But for a dev client build to pick it up properly, it shouldn't include the |
Came here with the same problem and agree with @oscar-b: I think if the URL would start with scheme:// it would be fine, but the exp+ part leads to iPhone saying, "No usable data found" when scanning the QR code. |
@byCedric Is the intention to not change the existing scheme but to add a new scheme to prepend the Separately, I don't think our apps are actually getting the |
@byCedric The ticket is marked with |
In this case, generating the QR code to dev-client, is it possible to open the app without having the server running in a pc, because when I was using managed workflow, the QA team could only have the expo go app and then scan the QR code and then see the new feature, but is it possible to have the same behaviour with dev-client QR codes? |
Yea, I just realized this as well, I tried to generate qr code on my PR but on my iPhone it says Edit: |
Hey all! Sorry for my late response. I was out sick and busy with other work. I saw a few things being discussed here, so let me go through them individually.
This is something we use internally within various Expo tools. We do add the But, if you all mention that this isn't working, I guess we can't rely on that and we need to find something else for this.
I was waiting on my initial question related to the I'll circle back to this during the SDK 49 beta release! |
@byCedric Just for reference, the URL I'm currently generating that works look like this:
Where |
Reiterating what @ardasatata said above, I would really like to see a flag for the So, like others, I'm now turning off the comment feature on the - name: 🚀 Create preview
id: expo_preview
uses: expo/expo-github-action/preview@v8
with:
command: eas update --auto --non-interactive
comment: false # see the step below for why we do this
# Because of https://github.com/expo/expo-github-action/issues/214, we have to generate our own QR code for now.
# They need to allow publishing a QR code without the schema for ExpoGO to "just work"
- name: 📝 Comment on PR
uses: edumserrano/find-create-or-update-comment@v1
with:
issue-number: ${{ github.event.pull_request.number }}
body-includes: "<!-- expo-qr-code -->"
comment-author: "github-actions[bot]"
body: |
<!-- expo-qr-code -->
### <MY_APP_NAME> Preview
<table>
<tr>
<td><b>Project
<td><b>Channel
<td><b>Project Link
<tr>
<td>${{ steps.expo_preview.outputs.projectName }}
<td>${{ steps.preview_channel.outputs.channel }}
<td><a href="${{ steps.expo_preview.outputs.link }}">${{ steps.expo_preview.outputs.link }}</a>
</table>
-----
**Option 1 - 📱 Scan QR Code**
<img src="https://qr.expo.dev/eas-update/?projectId=${{ steps.expo_preview.outputs.projectId }}&groupId=${{ steps.expo_preview.outputs.groupId }}" height="200px" width="200px" />
**Option 2 - 📱 Open Link**
[exp://u.expo.dev/${{ steps.expo_preview.outputs.projectId }}/group/${{ steps.expo_preview.outputs.groupId }}](exp://u.expo.dev/${{ steps.expo_preview.outputs.projectId }}/group/${{ steps.expo_preview.outputs.groupId }})
edit-mode: replace Interestingly, the Expo webapp even supports this behavior (defaulting to expo go). You can see this on your project at https://expo.dev/accounts//projects/<PROJECT_NAME>/updates/ So, in general, it feels like this should be easily customizable, even maybe defaulting to ExpoGO links, not the |
I am using this with a custom app build. My workaround is to define the app scheme only for pr builds, eg. - name: 🚀 Create preview
id: expo_preview
uses: expo/expo-github-action/preview@v8
env:
PR_PREVIEW: true
with:
command: eas update --auto --non-interactive // app.config.ts
export default ({ config }: ConfigContext): ExpoConfig => {
return {
// ...
scheme: process.env.PR_PREVIEW === "true" ? "my-own-dev-client-scheme" : undefined,
// ...
}
} |
This is my current job for QR code branch preview, it's a managed project with development-client (not expo go). Works like a charm and it points straight to dev-client, I hope it helps you!
|
Added more context here: #240 |
Description of the feature
How would you briefly summarise the feature?
The current QR code generated only works for Expo Go builds. Scanning the QR code opens Expo Go (which obviously fails). Should support an option to generate a QR code that opens the development build instead.
Right now we have to manually generate it in the comment parameter as follows:
Motivation
Why does this feature should be implemented?
So that we don't have to manually generate the dev-client QR code
Additional context
Can you further explain the feature? E.g., screenshots or real-world examples.
The text was updated successfully, but these errors were encountered: