Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo SDK 43 points to an incompatible version of react-native-maps #14940

Closed
bartvanandel opened this issue Oct 28, 2021 · 6 comments
Closed

Comments

@bartvanandel
Copy link

Summary

Just upgrated our app from Expo SDK 42 to 43, only to find out that this introduced a dependency clash when react-native-maps is also used, making npm install fail. The issue is however also present in the current version of react-native-maps, so an actual fix will have to wait until this related issue is resolved: react-native-maps/react-native-maps#3992 (more details there as well).

Managed or bare workflow? If you have ios/ or android/ directories in your project, the answer is bare!

managed

What platform(s) does this occur on?

Android, iOS, Web

SDK Version (managed workflow only)

43

Environment

NB: this could only be retrieved after running npm install --force

Expo CLI 4.12.10 environment info:
System:
OS: Windows 10 10.0.19043
Binaries:
Node: 16.12.0 - C:\ProgramData\scoop\apps\nvm\current\nodejs\nodejs\node.EXE
npm: 8.1.0 - C:\ProgramData\scoop\apps\nvm\current\nodejs\nodejs\npm.CMD
npmPackages:
expo: ~43.0.0 => 43.0.1
react: 17.0.1 => 17.0.1
react-dom: 17.0.1 => 17.0.1
react-native: 0.64.2 => 0.64.2
react-native-web: 0.17.1 => 0.17.1
Expo Workflow: managed

Reproducible demo or steps to reproduce from a blank project

npm i -g expo-cli
mkdir expo-test
expo init                       # and accept all defaults...
cd my-app
expo install react-native-maps  # this errors out due to dependency conflicts,
                                # but it does add the package to package.json
npm install --force             # this resolved it for our situation, no guarantees though
@bartvanandel bartvanandel added the needs validation Issue needs to be validated label Oct 28, 2021
@brentvatne
Copy link
Member

there isn't much we can do about this from the expo side, we'll need the library to update their peer dependencies. i commented on the issue on their repo

@bartvanandel
Copy link
Author

I know, but this way you're aware of the situation and of the upstream issue report. And others can find this issue as well.

@byCedric byCedric added MapView and removed needs validation Issue needs to be validated labels Oct 29, 2021
@brentvatne
Copy link
Member

@bartvanandel - appreciated!

@bartvanandel
Copy link
Author

bartvanandel commented Nov 11, 2021

The upstream issue has been fixed and a new version of the packagehas been released! See linked remote issue and PR for more info. Summary from react-native-maps (quote):

Changes published to 0.28.1 and 0.29.4.

@bartvanandel
Copy link
Author

@brentvatne @byCedric I could prepare a PR but I'm quite sure that the time it would take me to create one plus review cycle is far larger than the time it takes you to update the dependency directly. So, how to proceed?

@brentvatne
Copy link
Member

@bartvanandel - i updated the version to 0.28.1, you should get this when you run expo install react-native-maps now

thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants