-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expo SDK 43 points to an incompatible version of react-native-maps #14940
Comments
there isn't much we can do about this from the expo side, we'll need the library to update their peer dependencies. i commented on the issue on their repo |
I know, but this way you're aware of the situation and of the upstream issue report. And others can find this issue as well. |
@bartvanandel - appreciated! |
The upstream issue has been fixed and a new version of the packagehas been released! See linked remote issue and PR for more info. Summary from react-native-maps (quote):
|
@brentvatne @byCedric I could prepare a PR but I'm quite sure that the time it would take me to create one plus review cycle is far larger than the time it takes you to update the dependency directly. So, how to proceed? |
@bartvanandel - i updated the version to 0.28.1, you should get this when you run thanks for following up! |
Summary
Just upgrated our app from Expo SDK 42 to 43, only to find out that this introduced a dependency clash when react-native-maps is also used, making
npm install
fail. The issue is however also present in the current version of react-native-maps, so an actual fix will have to wait until this related issue is resolved: react-native-maps/react-native-maps#3992 (more details there as well).Managed or bare workflow? If you have
ios/
orandroid/
directories in your project, the answer is bare!managed
What platform(s) does this occur on?
Android, iOS, Web
SDK Version (managed workflow only)
43
Environment
NB: this could only be retrieved after running
npm install --force
Expo CLI 4.12.10 environment info:
System:
OS: Windows 10 10.0.19043
Binaries:
Node: 16.12.0 - C:\ProgramData\scoop\apps\nvm\current\nodejs\nodejs\node.EXE
npm: 8.1.0 - C:\ProgramData\scoop\apps\nvm\current\nodejs\nodejs\npm.CMD
npmPackages:
expo: ~43.0.0 => 43.0.1
react: 17.0.1 => 17.0.1
react-dom: 17.0.1 => 17.0.1
react-native: 0.64.2 => 0.64.2
react-native-web: 0.17.1 => 0.17.1
Expo Workflow: managed
Reproducible demo or steps to reproduce from a blank project
The text was updated successfully, but these errors were encountered: