Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Stop prebuilding packages on publish #20737

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Jan 6, 2023

Why

Prebuilding native packages to make compilation faster was generally a good idea, but it turned out to bring more troubles than gains, especially when someone's Xcode version was not matching the one used by the publisher.
Right now, since many of packages are in Swift, it no longer makes sense to prebuild them.
We already disabled prebuilding for many packages, so this PR is just a sunset of that idea.

How

Removed prebuilding tasks from the publish pipeline

Test Plan

Not even necessary 馃槄

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jan 6, 2023
@tsapeta tsapeta marked this pull request as ready for review January 6, 2023 23:07
@tsapeta tsapeta merged commit c49814c into main Jan 9, 2023
@tsapeta tsapeta deleted the @tsapeta/tools/stop-prebuilding-on-publish branch January 9, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants