Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add possible remedy for Hermes debugger problems when the project is not served on LAN connection #20739

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

Nantris
Copy link
Contributor

@Nantris Nantris commented Jan 7, 2023

To clarify: the remedy works, just can't guarantee it works for everyone.

Why

Hermes troubleshooting steps helped to uncover the problem, but not solve it.

Checklist

To clarify: the remedy works, just can't guarantee it works for everyone.
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jan 7, 2023
Copy link
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the remedy. Left a small suggestion to have consistent verbiage.

docs/pages/guides/using-hermes.mdx Outdated Show resolved Hide resolved
@amandeepmittal amandeepmittal changed the title Add possible remedy for Hermes debugger problems [docs] Add possible remedy for Hermes debugger problems when the project is not served on LAN connection Jan 17, 2023
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
@Nantris
Copy link
Contributor Author

Nantris commented Jan 17, 2023

@amandeepmittal thanks for the edit. I've found it may also be necessary to --clear-cache once the issue has occurred on a non-working method.

ie --lan doesn't work, so you try tunnel - but --tunnel will only work if you use --tunnel --clear-cache (but --clear-cache alone seems to have no effect.) I'm not sure how to update the wording to reflect that new finding. Any suggestion?

@amandeepmittal
Copy link
Member

@slapbox, I don't think --clear-cache is a valid flag for npx expo start. Are you using the local versioned CLI that comes with Expo package in your project?

@Nantris
Copy link
Contributor Author

Nantris commented Jan 18, 2023

Are you using the local versioned CLI that comes with Expo package in your project?

Yes, via yarn expo start

@amandeepmittal
Copy link
Member

amandeepmittal commented Jan 19, 2023

The flag is --clear. You can also check that by running yarn expo start --help inside the Expo project.

Here is an output of that command:
CleanShot 2023-01-19 at 22 22 27@2x

I'm not sure why you are running --clear-cache and why is it working in your case but you did mention it has no effect. I also don't think -c or --clear is necessary with --tunnel. The purpose of the flag is when there are changes in babel.config.js file or when some things are done with symlinks, in those cases, the flag is required.

@Nantris
Copy link
Contributor Author

Nantris commented Jan 19, 2023

Not sure what to say. I can only report what has worked here. Perhaps passing an invalid flag somehow influences whether the debugger can connect or not. Or maybe I was using --clear and I'm conflating it with --clear-cache in EAS.

I'll loop back next time I run into this issue and report what worked.

@amandeepmittal
Copy link
Member

No worries at all! Feel free to open an issue if you find anything weird 😄

I'm going to merge this with the current changes. Thanks for your contribution!!!

@amandeepmittal amandeepmittal merged commit b576867 into expo:main Jan 19, 2023
@Nantris
Copy link
Contributor Author

Nantris commented May 10, 2023

@amandeepmittal, just an update: these days (with SDK 48) I'm noticing yarn expo start --lan almost always works without any other flags needed. I never need to clear the cache anymore for it to work but I always need --lan or I get the message about the debugger only working with Hermes apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants