Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-image] [iOS] Some blurhashes are broken when used in combination of SDK 48 #21404

Closed
xmflsct opened this issue Feb 25, 2023 · 8 comments · Fixed by #21569
Closed

[expo-image] [iOS] Some blurhashes are broken when used in combination of SDK 48 #21404

xmflsct opened this issue Feb 25, 2023 · 8 comments · Fixed by #21569

Comments

@xmflsct
Copy link

xmflsct commented Feb 25, 2023

Minimal reproducible example

https://github.com/xmflsct/test-blurhash

Summary

Showcase expo-image is broken on some blurhashes, compared with react-native-blurhash side by side.

This is observed only after using together with expo version after 48.0.0-beta.2, basically all the GA versions would fail some blurhashes.

Environment

expo-env-info 1.0.5 environment info:
System:
OS: macOS 13.2.1
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.14.0 - ~/.nvm/versions/node/v18.14.0/bin/node
Yarn: 3.3.1 - ~/.nvm/versions/node/v16.19.0/bin/yarn
npm: 9.3.1 - ~/.nvm/versions/node/v18.14.0/bin/npm
Managers:
CocoaPods: 1.11.3 - /Users/---/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9123335
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
npmPackages:
expo: ~48.0.4 => 48.0.4
react: 18.2.0 => 18.2.0
react-native: 0.71.3 => 0.71.3
Expo Workflow: managed

@xmflsct xmflsct added the needs validation Issue needs to be validated label Feb 25, 2023
@brentvatne brentvatne added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels Feb 25, 2023
@brentvatne
Copy link
Member

@xmflsct - are you noticing this on ios, android, or both?

@brentvatne brentvatne added Image Issue accepted and removed needs review Issue is ready to be reviewed by a maintainer labels Feb 25, 2023
@expo-bot
Copy link
Collaborator

Thank you for filing this issue!
This comment acknowledges we believe this may be a bug and there’s enough information to investigate it.
However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

@xmflsct
Copy link
Author

xmflsct commented Feb 25, 2023

@brentvatne oh forgot to mention, iOS only. Android is working perfectly fine.

@xmflsct xmflsct changed the title [expo-image] Some blurhashes are broken when used in combination of SDK 48 [expo-image] [iOS] Some blurhashes are broken when used in combination of SDK 48 Feb 25, 2023
@yoann84
Copy link

yoann84 commented Mar 1, 2023

Exact same problem here with ios and expo sdk48.
Working properly on android.

@glundgrenm
Copy link

glundgrenm commented Mar 2, 2023

I am having the same issue, only iOS. Expo 48, expo go.

I think its the characters, this doesnt work: L5NTzf}YM{n$0.#loLoL3Y9tRjjY

But i removed some chars, replaced the . and # to 0 and this worked: L5NTzf}YM{n$000loLoL3Y9tRjjY

@shollington-rbi
Copy link

Here's another one that breaks: e47BApj[00ayRjD%azayj[?I00j[_4ayxu_3j[WBay4nt7ayofofM{

Also confirming that it is only broken on iOS - Android; and Web are both working fine. Expo SDK 48.0.2.

@tsapeta
Copy link
Member

tsapeta commented Mar 14, 2023

I've just published expo@48.0.7 that should fix this issue. I would really appreciate if someone could try it out and confirm whether it works 🙂

@xmflsct
Copy link
Author

xmflsct commented Mar 14, 2023

Thank you @tsapeta! I can confirm it is now working correctly for blurhashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants