[expo-modules-core][1.5.6] Crash when launching project through dev-client #23451

thespacemanatee · 2023-07-11T07:41:53Z

Minimal reproducible example

https://github.com/thespacemanatee/expo-dev-menu-repro/tree/regression/expo-modules-core-url-crash

Summary

There is a regression caused by (EDIT: #23405). I'm on expo@49.0.2 and expo-modules-core@1.5.6 and on Debug builds I'm getting the following error after launching the dev-client via deep-link or through the UI:

Thread 7 Crashed::  Dispatch queue: com.apple.NSURLSession-delegate
0   libswiftCore.dylib            	       0x18bcdc794 closure #1 in closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:) + 288
1   libswiftCore.dylib            	       0x18bcdc544 closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:) + 196
2   libswiftCore.dylib            	       0x18bcdc43c closure #1 in _assertionFailure(_:_:file:line:flags:) + 328
3   libswiftCore.dylib            	       0x18bcdc034 _assertionFailure(_:_:file:line:flags:) + 168
4   Padlet                        	       0x10450ba80 closure #1 in FileDownloader.downloadData(withRequest:successBlock:errorBlock:) + 1588 (FileDownloader.swift:1016)
5   Padlet                        	       0x10450e2e4 partial apply for closure #1 in FileDownloader.downloadData(withRequest:successBlock:errorBlock:) + 44
6   Padlet                        	       0x10450c0e4 thunk for @escaping @callee_guaranteed @Sendable (@guaranteed Data?, @guaranteed NSURLResponse?, @guaranteed Error?) -> () + 280
7   Padlet                        	       0x1047e608c __InstrumentDataTaskWithRequestCompletionHandler_block_invoke_2 + 252 (FPRNSURLSessionInstrument.m:307)
8   Padlet                        	       0x1047e608c __InstrumentDataTaskWithRequestCompletionHandler_block_invoke_2 + 252 (FPRNSURLSessionInstrument.m:307)
9   CFNetwork                     	       0x183d30cf8 0x183d2a000 + 27896
10  CFNetwork                     	       0x183d4c170 0x183d2a000 + 139632
11  libdispatch.dylib             	       0x180132ee4 _dispatch_call_block_and_release + 24
12  libdispatch.dylib             	       0x180134708 _dispatch_client_callout + 16
13  libdispatch.dylib             	       0x18013c77c _dispatch_lane_serial_drain + 776
14  libdispatch.dylib             	       0x18013d414 _dispatch_lane_invoke + 448
15  libdispatch.dylib             	       0x180149608 _dispatch_workloop_worker_thread + 768
16  libsystem_pthread.dylib       	       0x1b1834878 _pthread_wqthread + 284
17  libsystem_pthread.dylib       	       0x1b183363c start_wqthread + 8

FileDownLoader.swift is in the expo-updates project, and on this particular line, an URL is created, but fails and goes to the errorBlock on line 1016.

Release build is not affected.

Environment

expo-env-info 1.0.5 environment info:
    System:
      OS: macOS 13.3.1
      Shell: 5.9 - /bin/zsh
    Binaries:
      Node: 16.15.0 - ~/.asdf/installs/nodejs/16.15.0/bin/node
      Yarn: 1.22.19 - ~/.asdf/installs/nodejs/16.15.0/bin/yarn
      npm: 8.5.5 - ~/.asdf/plugins/nodejs/shims/npm
      Watchman: 2023.04.17.00 - /opt/homebrew/bin/watchman
    Managers:
      CocoaPods: 1.12.1 - /Users/honeycomb/.asdf/shims/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    IDEs:
      Android Studio: Hedgehog 2023.1.1 Canary 11 Hedgehog 2023.1.1 Canary 11
      Xcode: 14.3/14E222b - /usr/bin/xcodebuild
    npmPackages:
      expo: ~49.0.2 => 49.0.2 
      react: 18.2.0 => 18.2.0 
      react-native: 0.72.1 => 0.72.1 
    npmGlobalPackages:
      eas-cli: 3.13.3
      expo-cli: 6.3.7
    Expo Workflow: bare

The text was updated successfully, but these errors were encountered:

alanjhughes · 2023-07-11T08:08:34Z

@thespacemanatee - Unclear to me how this related to that PR? data.write(to: URL(fileURLWithPath: destinationPath) is a system api. It has nothing to do with expo-modules-core.

thespacemanatee · 2023-07-11T08:12:45Z

@alanjhughes it's unclear to me too, however the PR modifies URL in Convertibles.swift (see here) which is an extension of URL in Foundation, so it definitely has something to do with expo-modules-core. I've given the repro as well so it should be fairly straightforward to figure out what was the actual regression between 1.5.4 and 1.5.6.

alanjhughes · 2023-07-11T08:17:15Z

Yes and convertibles are used when converting arguments from Javascript. It's not being used here. Extensions don't affect the behaviour of default initializers. I've cloned your example and ran it without issue

thespacemanatee · 2023-07-11T08:30:09Z

Did you clone the correct branch? Check expo-modules-core-url-crash

thespacemanatee · 2023-07-11T09:39:19Z

@alanjhughes I'll add that doing

"resolutions": {
  "expo-modules-core": "1.5.5"
}

fixes it, so it should be a regression caused 1.5.6 instead, sorry for the mistake. It should be caused by #23405 @Kudo

alanjhughes · 2023-07-11T10:00:28Z

@thespacemanatee - I've reproduced it. I'll look into it 👍

expo-bot · 2023-07-11T10:56:40Z

Thank you for filing this issue!
This comment acknowledges we believe this may be a bug and there’s enough information to investigate it.
However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

CruelMoney · 2023-07-11T11:42:08Z

@alanjhughes I'll add that doing
"resolutions": {
  "expo-modules-core": "1.5.5"
}
fixes it, so it should be a regression caused 1.5.6 instead, sorry for the mistake. It should be caused by #23405 @Kudo

This fixed the issue for me as well.

jozzzaa · 2023-07-12T18:22:13Z

@alanjhughes I'll add that doing
"resolutions": {
  "expo-modules-core": "1.5.5"
}
fixes it, so it should be a regression caused 1.5.6 instead, sorry for the mistake. It should be caused by #23405 @Kudo

I am having issues with this resolution. I have added to package.json, deleted node_modules and reinstalled and rebuilt my dev client on EAS. Any idea how to get this workaround to work?

davecalnan · 2023-07-12T21:04:35Z

@alanjhughes I'll add that doing
"resolutions": {
  "expo-modules-core": "1.5.5"
}
fixes it, so it should be a regression caused 1.5.6 instead, sorry for the mistake. It should be caused by #23405 @Kudo

Note that if you're using pnpm with a monorepo you will need to add this to the root package.json:

{
  "resolutions": {
    "expo-modules-core": "1.5.5"
  }
}

This is an alias for pnpm.overrides so this is equivalent to:

{
  "pnpm": {
    "overrides": {
      "expo-modules-core": "1.5.5"
    }
  }
}

Run pnpm install and you should see a change to pnpm-lock.yaml. I found using pnpm why expo-modules-core helpful to check which version was being installed.

See https://pnpm.io/package_json#pnpmoverrides

tsapeta · 2023-07-12T21:16:28Z

While resolutions/overrides are sometimes ok as workarounds, please keep in mind that this is just a temporary thing and should eventually be removed when you upgrade the expo package. expo-modules-core is not intended to be a direct dependency of the project – expo package should be the only one that controls its version. Otherwise, this may lead to some other issues and dependency conflicts. In this specific case, downgrading the expo package would be a better choice than overriding expo-modules-core.

By the way, expo@49.0.3 that should fix this problem has been released 🥳

thespacemanatee · 2023-07-16T14:35:50Z

@tsapeta agree. I only posted the overrides 'solution' to bring attention to the fact that 1.5.6 introduced a regression.

thespacemanatee added the needs validation Issue needs to be validated label Jul 11, 2023

expo-bot added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels Jul 11, 2023

alanjhughes added Issue accepted and removed needs review Issue is ready to be reviewed by a maintainer labels Jul 11, 2023

alanjhughes self-assigned this Jul 11, 2023

Kudo mentioned this issue Jul 12, 2023

[core] reland #23405 #23491

Merged

3 tasks

tsapeta closed this as completed in #23491 Jul 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[expo-modules-core][1.5.6] Crash when launching project through dev-client #23451

[expo-modules-core][1.5.6] Crash when launching project through dev-client #23451

thespacemanatee commented Jul 11, 2023 •

edited

alanjhughes commented Jul 11, 2023 •

edited

thespacemanatee commented Jul 11, 2023 •

edited

alanjhughes commented Jul 11, 2023 •

edited

thespacemanatee commented Jul 11, 2023

thespacemanatee commented Jul 11, 2023 •

edited

alanjhughes commented Jul 11, 2023

expo-bot commented Jul 11, 2023

CruelMoney commented Jul 11, 2023

jozzzaa commented Jul 12, 2023

davecalnan commented Jul 12, 2023

tsapeta commented Jul 12, 2023

thespacemanatee commented Jul 16, 2023

[expo-modules-core][1.5.6] Crash when launching project through dev-client #23451

[expo-modules-core][1.5.6] Crash when launching project through dev-client #23451

Comments

thespacemanatee commented Jul 11, 2023 • edited

Minimal reproducible example

Summary

Environment

alanjhughes commented Jul 11, 2023 • edited

thespacemanatee commented Jul 11, 2023 • edited

alanjhughes commented Jul 11, 2023 • edited

thespacemanatee commented Jul 11, 2023

thespacemanatee commented Jul 11, 2023 • edited

alanjhughes commented Jul 11, 2023

expo-bot commented Jul 11, 2023

CruelMoney commented Jul 11, 2023

jozzzaa commented Jul 12, 2023

davecalnan commented Jul 12, 2023

tsapeta commented Jul 12, 2023

thespacemanatee commented Jul 16, 2023

thespacemanatee commented Jul 11, 2023 •

edited

alanjhughes commented Jul 11, 2023 •

edited

thespacemanatee commented Jul 11, 2023 •

edited

alanjhughes commented Jul 11, 2023 •

edited

thespacemanatee commented Jul 11, 2023 •

edited