Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Types of config properties are not reflected properly #25516

Closed
nop33 opened this issue Nov 22, 2023 · 0 comments · Fixed by #26255
Closed

[docs] Types of config properties are not reflected properly #25516

nop33 opened this issue Nov 22, 2023 · 0 comments · Fixed by #26255
Labels

Comments

@nop33
Copy link
Contributor

nop33 commented Nov 22, 2023

Summary

I was looking at the docs of the scheme property to see if I can set multiple schemes. The docs look as follows:

image

As you can see, the type is set to undefined. I tried to edit the page, and I was led to this file: https://github.com/expo/expo/blob/main/docs/public/static/schemas/unversioned/app-config-schema.json

There I can see that the type is correctly set to:

{
   "oneOf":[
      {
         "type":"string",
         "pattern":"^[a-z][a-z0-9+.-]*$"
      },
      {
         "type":"array",
         "items":{
            "type":"string",
            "pattern":"^[a-z][a-z0-9+.-]*$"
         }
      }
   ]
}

So the bug seems to be somewhere in the AppConfigSchemaPropertiesTable component that doesn't render properly. It seems that it only looks for the type property and not for the oneOf: https://github.com/expo/expo/blob/main/docs/components/plugins/AppConfigSchemaPropertiesTable.tsx#L23

Link to the related docs page

https://docs.expo.dev/versions/latest/config/app/#scheme

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant