Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expo-image-manipulator removes most exif data #28913

Closed
nojas01 opened this issue May 16, 2024 · 1 comment
Closed

expo-image-manipulator removes most exif data #28913

nojas01 opened this issue May 16, 2024 · 1 comment
Labels
invalid issue: feature request Issues on this repository are reserved for bug reports needs review Issue is ready to be reviewed by a maintainer

Comments

@nojas01
Copy link

nojas01 commented May 16, 2024

Minimal reproducible example

https://github.com/nojas01/expo_no_exif

What platform(s) does this occur on?

Android, iOS

Did you reproduce this issue in a development build?

Yes

Summary

Expo camera offers the option to add additional Exif to a photo. Expo-image-manipulator offers the functionality to scale, rotate and much more with the same photo. However if you add Exif to a photo you expect it to still be there after you manipulate the image and update the props that have changed with the manipulation (like width and height).

// exif after taking a photo:

{"SubSecTimeDigitized":"315","UserComment":"This is a valid exif field","ApertureValue":1.69,"ImageLength":3024,"LightSource":0,"ColorSpace":1,"Flash":2,"YCbCrPositioning":1,"Orientation":6,"ResolutionUnit":2,"FocalLengthIn35mmFilm":26,"SubSecTime":"315","MeteringMode":2,"DateTimeDigitized":"2024:05:16 10:52:38","ExposureProgram":2,"SceneCaptureType":0,"WhiteBalance":0,"ComponentsConfiguration":"???","Make":"samsung","DateTimeOriginal":"2024:05:16 10:52:38","ExposureTime":0.02,"SubSecTimeOriginal":"315","YResolution":72,"ImageWidth":4032,"ExifVersion":"0220","FNumber":1.8,"Model":"SM-G991B","MaxApertureValue":1.8,"ISOSpeedRatings":80,"FocalLength":5.4,"XResolution":72,"Software":"G991BXXSAFXCL","DateTime":"2024:05:16 10:52:38","ImageUniqueID":"R12LLMF00SM R12LLMF00SM?"}

// exif after manipulate:

{"LightSource":0,"ImageLength":0,"Orientation":0,"ImageWidth":0}

Environment

expo-env-info 1.2.0 environment info:
System:
OS: macOS 14.4.1
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node
npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm
Watchman: 2024.04.08.00 - /opt/homebrew/bin/watchman
SDKs:
iOS SDK:
Platforms: DriverKit 23.5, iOS 17.5, macOS 14.5, tvOS 17.5, visionOS 1.2, watchOS 10.5
IDEs:
Xcode: 15.4/15F31d - /usr/bin/xcodebuild
npmPackages:
expo: ~51.0.7 => 51.0.7
expo-router: ~3.5.14 => 3.5.14
react: 18.2.0 => 18.2.0
react-dom: 18.2.0 => 18.2.0
react-native: 0.74.1 => 0.74.1
react-native-web: ~0.19.10 => 0.19.11
Expo Workflow: managed

Expo Doctor Diagnostics

✔ Check Expo config for common issues
✔ Check package.json for common issues
✔ Check native tooling versions
✔ Check dependencies for packages that should not be installed directly
✔ Check for common project setup issues
✔ Check npm/ yarn versions
✔ Check for issues with metro config
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check that native modules do not use incompatible support packages
✔ Check for legacy global CLI installed locally
✔ Check that packages match versions required by installed Expo SDK
✔ Check that native modules use compatible support package versions for installed Expo SDK

Didn't find any issues with the project!

@nojas01 nojas01 added the needs validation Issue needs to be validated label May 16, 2024
@expo-bot expo-bot added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels May 16, 2024
@brentvatne brentvatne added the invalid issue: feature request Issues on this repository are reserved for bug reports label May 17, 2024
@expo-bot
Copy link
Collaborator

Hello! Our GitHub issues are reserved for bug reports.

If you would like to request a feature, please post to https://expo.canny.io/feature-requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid issue: feature request Issues on this repository are reserved for bug reports needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants