Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings when static permissions config isn't present #3630

Closed
brentvatne opened this issue Mar 2, 2019 · 4 comments
Closed

Add warnings when static permissions config isn't present #3630

brentvatne opened this issue Mar 2, 2019 · 4 comments
Labels

Comments

@brentvatne
Copy link
Member

It'd be useful whenever we need permissions to add a static check like this: https://github.com/react-native-community/react-native-cameraroll/blob/4777d0554612f816e9c9714028f58e613231a383/ios/RNCCameraRollManager.m#L338-L345 - then if people forget to add it in their bare app they can be guided by the error message.

@EvanBacon
Copy link
Contributor

Xcode automatically does this and we surface simulator error messages in expo run:ios.

@brentvatne
Copy link
Member Author

i suspect now that we surface this from expo run:ios, it will help. i created this issue because i saw a trend of people omitting the description key and then being confused about how to resolve the issue. i believe the behavior is often for the app to crash outright in this situation - a warning or a red screen is preferred imo.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Mar 8, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants