Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with when onEnd prop is called for video #51

Closed
pooolz opened this issue Feb 4, 2017 · 1 comment
Closed

Inconsistency with when onEnd prop is called for video #51

pooolz opened this issue Feb 4, 2017 · 1 comment

Comments

@pooolz
Copy link

pooolz commented Feb 4, 2017

When passing in the onEnd prop:

If video playback has already reached the end of the video, exiting fullscreen mode will trigger the onEnd event a second time (it already fired once when the playback reached the end).

If video playback has NOT reached the end of the video, exiting fullscreen mode will not trigger onEnd event

Exiting fullscreen should either always invoke onEnd, or never invoke onEnd.

@gkufera
Copy link
Contributor

gkufera commented Jun 7, 2017

Hi @Samwise00!

We just did a revamp of the Video component in SDK17, and this behavior should be gone. We actually do not include an onEnd prop anymore, and this functionality has been consumed by the callback prop. See the docs for more info on the new API.

Thanks!

@gkufera gkufera closed this as completed Jun 7, 2017
@lock lock bot added the outdated label Jun 16, 2019
@lock lock bot unassigned gkufera Jun 16, 2019
@lock lock bot locked and limited conversation to collaborators Jun 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants