Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'EXBranch/EXBranchManager.h' file not found on blank ejected ExpoKit project #5231

Closed
mjgallag opened this issue Aug 7, 2019 · 9 comments
Closed
Assignees

Comments

@mjgallag
Copy link
Contributor

mjgallag commented Aug 7, 2019

🐛 Bug Report

iOS build is currently failing for a new completely blank ejected ExpoKit projects.

The workaround is to revert ExpoKit pod tag to ios/2.12.1 from ios/2.12.3 in your Podfile here.

Environment

  Expo CLI 3.0.9 environment info:
    System:
      OS: macOS 10.14.6
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 10.16.2 - /usr/local/bin/node
      npm: 6.9.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    IDEs:
      Android Studio: 3.4 AI-183.6156.11.34.5692245
      Xcode: 10.3/10G8 - /usr/bin/xcodebuild
    npmPackages:
      expo: ^34.0.1 => 34.0.4 
      react: 16.8.3 => 16.8.3 
      react-native: https://github.com/expo/react-native/archive/sdk-34.0.1.tar.gz => 0.59.8 
    npmGlobalPackages:
      expo-cli: 3.0.9

Steps to Reproduce

  1. clone https://github.com/thunkable/expo-kit-diff (this is just a new completely blank ejected ExpoKit project)
  2. cd expo-kit-diff
  3. npm install
  4. (cd ios && pod install)
  5. npx react-native run-ios --no-packager

Actual Behavior

❌  /Users/Mike/Documents/expo-kit-diff/expo-kit-diff/ios/Pods/ExpoKit/ios/Exponent/Kernel/Services/EXScopedBranchManager.h:4:9: 'EXBranch/EXBranchManager.h' file not found

#import <EXBranch/EXBranchManager.h>
            ^
@mjgallag mjgallag added the bug label Aug 7, 2019
@owenhope
Copy link

owenhope commented Aug 7, 2019

Experiencing the same issue with 2.12.3

Unfortunately when I downgrade to 2.12.1 I receive this error whenever I use the getLatestReferringParams

Simulator Screen Shot - iPhone Xʀ - 2019-08-07 at 16 39 09

@razvananton21
Copy link

razvananton21 commented Aug 8, 2019

is there any fix for this issue? I encountered it too.

@changLiuUNSW
Copy link
Contributor

Get the same issue

@RodolfoGS
Copy link
Contributor

Same issue. I fixed it downgrading to ios/2.12.1

@qiongyue
Copy link

qiongyue commented Aug 9, 2019

missing expo-branch module, you can install it with yarn or npm,then pod install and rebuild again

yarn add expo-branch

cd ios

pod install

@RodolfoGS
Copy link
Contributor

@qiongyue thank you! Works great using ios/2.12.3

npm install expo-branch
cd ios/
pod install

@sjchmiela
Copy link
Contributor

My bad, this shouldn't have happened, I'll release a proper fix asap, hang on

@sjchmiela
Copy link
Contributor

If you don't intend to use Branch in your app, you should be able to remove expo-branch. Then, upgrade the pod to ios/2.12.4 tag. This should fix the issue.

If you intend to use Branch, leave expo-branch installed (but also upgrade to ios/2.12.4, for clarity's sake 😅).

@mjgallag
Copy link
Contributor Author

mjgallag commented Aug 9, 2019

@sjchmiela I can confirm that it works, thanks! FYI, I'm sure you already know this, but the new ExpoKit project template is still pointing to the broken ios/2.12.3. Until we get onto the bare workflow I upgrade ExpoKit by merging in from a brand new ExpoKit project to make sure I don't miss anything thus I notice these things with https://github.com/thunkable/expo-kit-diff :)

@lock lock bot added the outdated label Feb 5, 2020
@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants