Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Detox iOS tests for CI #5984

Open
ide opened this issue Oct 16, 2019 · 4 comments
Open

Fix Detox iOS tests for CI #5984

ide opened this issue Oct 16, 2019 · 4 comments
Assignees
Labels
Projects

Comments

@ide
Copy link
Member

@ide ide commented Oct 16, 2019

The Detox tests are failing because the server never receives isReady after upgrading to RN 0.61. Rather than a timeout due to Earl Grey, it looks like there perhaps is an error on the client.

@ide ide added this to To do in SDK 36 via automation Oct 16, 2019
@ide ide mentioned this issue Oct 16, 2019
10 of 11 tasks complete
@EvanBacon

This comment has been minimized.

Copy link
Contributor

@EvanBacon EvanBacon commented Oct 24, 2019

@LeoNatan

This comment has been minimized.

Copy link

@LeoNatan LeoNatan commented Oct 27, 2019

Hello,
Just to explain. Detox should support RN61 already. The issue is with how RN is integrated in the user project, which in Detox' case is the internal test project.

Do you see isReady not being sent in a clean RN project (without expo)? If so, please open an issue on the Detox tracker.
Otherwise, that PR is for bureaucracy purposes only.

@EvanBacon

This comment has been minimized.

Copy link
Contributor

@EvanBacon EvanBacon commented Oct 30, 2019

The project we use Detox in (bare-expo) is a standard React Native project.

@kopax

This comment has been minimized.

Copy link

@kopax kopax commented Nov 12, 2019

Hello,
Just to explain. Detox should support RN61 already. The issue is with how RN is integrated in the user project, which in Detox' case is the internal test project.

Do you see isReady not being sent in a clean RN project (without expo)? If so, please open an issue on the Detox tracker.
Otherwise, that PR is for bureaucracy purposes only.

Hi. I have an app that I am thinking doing in react native and web with the same code base. It's imminent, do you think I should go with expo and if I do, will it be possible to upgrade to RN 0.61 without hassle ? I am also thinking of not using expo. I have no clue it is my first native web project and I want to target ios android and web. Any opinion and feedback is appreciated.

Best and thanks for sharing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
SDK 36
  
To do
5 participants
You can’t perform that action at this time.