Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalAuthentication does not match UX of other Android Apps in SDK37 #8246

Closed
ConorWatsonSoar opened this issue May 11, 2020 · 7 comments
Closed

Comments

@ConorWatsonSoar
Copy link

ConorWatsonSoar commented May 11, 2020

馃悰 Bug Report

Environment

  Expo CLI 3.20.1 environment info:
    System:
      OS: Linux 4.4 Ubuntu 18.04.1 LTS (Bionic Beaver)
      Shell: 5.4.2 - /usr/bin/zsh
    Binaries:
      Node: 12.9.1 - ~/.nvm/versions/node/v12.9.1/bin/node
      Yarn: 1.22.4 - ~/.yarn/bin/yarn
      npm: 6.14.4 - ~/.nvm/versions/node/v12.9.1/bin/npm
    npmPackages:
      expo: ^37.0.0 => 37.0.3
      react: 16.9.0 => 16.9.0
      react-dom: 16.9.0 => 16.9.0
      react-native: https://github.com/expo/react-native/archive/sdk-37.0.0.tar.gz => 0.61.4
      react-navigation: ^4.2.2 => 4.2.2
    npmGlobalPackages:
      expo-cli: 3.20.1

Targeting Android via Standalone and Client. Reproduced on a Samsung Galaxy S10+, with the latest version of the Expo Client installed (v2.15.0).

Steps to Reproduce

  1. Start/Upgrade a Project with SDK37
  2. Call LocalAuthentication.authenticateAsync()

Expected Behavior

Android Authentication UI should appear on top of the screen that is currently requests Authentication.

Regular Android Authentication
Regular Android Authentication

Actual Behavior

Android Authentication UI appears in a separate screen before the user is navigated back to their original screen.

SDK37 LocalAuthentication
SDK37 LocalAuthentication

Reproducible Demo

I have created a reproducible Snack demo here. I can also confirm that this problem is exhibited when a standalone app has been built in SDK37.

Interestingly, the UI appears correctly when using the Android simulator on the Snack. However running the Snack on my Samsung S10+ I can reproduce the unexpected behaviour, and my friend is also able to reproduce similar behaviour on his One Plus 7 Pro.

EDIT: I managed to get a hold of a Pixel 4, and the UI does appear correctly on this device. It's possible it's a "Custom" UI issue?

@rafatrace
Copy link

Any news on this? Its not something urgent, but we are thinking about implementing this at my company, would be nice to have this working

@sukso96100
Copy link

sukso96100 commented May 24, 2020

I can also see that UI appears in weird way. Since latest version of Localauthentication uses BiometricPrompt on Android, I think it should show system ui for biometric authentication like the photo below.
Screenshot_20200524-124507_Toss

On Samsung device with Android 10, Expo also shows the system biometric authentication ui. But in a bit weird way. Whether test it on expo client or standalone build, It shows the dialog on the seperate black empty screen.
Screenshot_20200519-151712_Settings
ezgif-7-cfc023deda43

And it seems like it only happens on Samsung device with Android 10. I tested the snack on Appetize.io with Android 10. And it showed the prompt properly.
Screenshot_20200524-153721_Chrome
ezgif-7-f4c5306a68f1

@ConorWatsonSoar
Copy link
Author

Seems like this is potentially an issue with Google blacklisting some of the major Samsung flagships. However there must be a solution as every Native app I use on the S10+ can display the Biometric Popup correctly.

@KiratiBhuva
Copy link

Hi, I am having the same issue with Samsung device, @ConorWatsonSoar did you find any solution for this issue?

@isidoro98
Copy link

Hey @ConorWatsonSoar @KiratiBhuva any updates on this ?

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Feb 17, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants