Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android-Only options Crash on IOS): IOS Crash on Android Options #144

Merged
merged 1 commit into from
Dec 13, 2019
Merged

fix(Android-Only options Crash on IOS): IOS Crash on Android Options #144

merged 1 commit into from
Dec 13, 2019

Conversation

IamMHC
Copy link
Contributor

@IamMHC IamMHC commented Dec 2, 2019

Crash on IOS

Android and web optional Options not available on IOS but when users use its work perfectly on web and Android but crash on IOS, Now This issue is fixed in this commit.

@IamMHC IamMHC changed the title fix(Android-Only options Crash on IOS): IOS Crash on Android-Only opt… fix(Android-Only options Crash on IOS): IOS Crash on Android Options Dec 2, 2019
@iamzadi
Copy link

iamzadi commented Dec 4, 2019

Good

@yilinjuang
Copy link

I've got this crash message

Error calling RCTEventEmitter.receiveTouches
Unhandled JS Exception: ... is not usable as a native method argument

@IamMHC is this the one your fixing? thanks

@IamMHC
Copy link
Contributor Author

IamMHC commented Dec 13, 2019

Yes, Now Android or Web optional props do not crash IOS Application

Copy link
Collaborator

@bradbyte bradbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bradbyte bradbyte merged commit 8016008 into expo:master Dec 13, 2019
bradbyte pushed a commit that referenced this pull request Dec 13, 2019
## [3.4.1](v3.4.0...v3.4.1) (2019-12-13)

### Bug Fixes

* **iOS:** crash when using Android only options ([#144](#144)) ([8016008](8016008))
@bradbyte
Copy link
Collaborator

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

robertomartinez09515 added a commit to robertomartinez09515/action-sheet-react-best-proj that referenced this pull request Jul 25, 2022
## [3.4.1](expo/react-native-action-sheet@v3.4.0...v3.4.1) (2019-12-13)

### Bug Fixes

* **iOS:** crash when using Android only options ([#144](expo/react-native-action-sheet#144)) ([8016008](expo/react-native-action-sheet@8016008))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants