Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: run ci on node 18 #305

Merged
merged 2 commits into from
Apr 24, 2022
Merged

meta: run ci on node 18 #305

merged 2 commits into from
Apr 24, 2022

Conversation

gamemaker1
Copy link
Member

Related Issues

--

What Does This PR Do?

Added

  • Runs Lint and Publish steps of CI on Node 18.
  • Added Node 18 to version matrix for Test steps too.

Caveats/Problems/Issues

--

Checklist

  • The issues that this PR fixes/closes have been mentioned above.
  • What this PR adds/changes/removes has been explained.
  • All tests (npm test) pass.
  • All added/modified code has been commented, and
    methods/classes/constants/types have been annotated with TSDoc comments.
  • If a new feature has been added or a bug has been fixed, tests have been
    added for the same.

@gamemaker1
Copy link
Member Author

@nfriedly should we stop running tests on Node 12? (EOL for Node 12 is April 30th, 6 days from now)

@nfriedly
Copy link
Member

I like adding 18 to the list, but I'd prefer to keep 12 unless there's some incompatibility with a feature that we (or, more likely, one of our dependencies) needs.

I think we could drop 15 and 17, though. Neither are LTS releases, and I find it unlikely that we'd hit any issue in on of those that isn't also in 14, 16, or 18. I generally like to test against a variety of LTS releases, + whatever the current release is.

@gamemaker1
Copy link
Member Author

Sounds good, I'll keep 12 but drop 15 and 17 then

Copy link
Member

@nfriedly nfriedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now based on our conversation; I'm going to be out most of the rest of the day.

@gamemaker1
Copy link
Member Author

Thanks, have a good day :D

@gamemaker1 gamemaker1 changed the title meta: run ci on node 18 as well meta: run ci on node 18 Apr 24, 2022
@gamemaker1 gamemaker1 merged commit c99ebae into master Apr 24, 2022
@gamemaker1 gamemaker1 deleted the meta/support-node-18 branch April 24, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants