Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm: correctly exclude .ts files when publishing with npm@7 #1035

Merged
merged 1 commit into from
May 8, 2021
Merged

npm: correctly exclude .ts files when publishing with npm@7 #1035

merged 1 commit into from
May 8, 2021

Conversation

fedeci
Copy link
Member

@fedeci fedeci commented May 8, 2021

Description

Closes #1034

This PR can be tested running npm publish --dry-run with npm@7 installed.

  • I have added tests for what I changed.
  • This pull request is ready to merge.

@fedeci fedeci requested a review from gustavohenke May 8, 2021 07:51
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 59f0117 on fedeci:fix-publish into 69c8fbb on express-validator:master.

gustavohenke
gustavohenke approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I did it again? 🤦

@gustavohenke gustavohenke merged commit 3acfe49 into express-validator:master May 8, 2021
@fedeci fedeci deleted the fix-publish branch May 9, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

Assignees
No one assigned
Labels
PR: npm typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema.ts Typescript compilation error - No overload matches this call
3 participants
@fedeci @coveralls @gustavohenke