Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added options support to isAlphanumeric #1037

Merged
merged 7 commits into from
May 16, 2021
Merged

Added options support to isAlphanumeric #1037

merged 7 commits into from
May 16, 2021

Conversation

trumankain
Copy link
Contributor

@trumankain trumankain commented May 10, 2021 •
edited by fedeci

Description

Added options support to isAlphanumeric, closes #1026

To-do list

  • I have added tests for what I changed.
  • This pull request is ready to merge.

fedeci
fedeci requested changes May 11, 2021
View reviewed changes
Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM with a couple of notes. Tests are not needed in this case because all the validators are supposed to be tested by validatorjs.

src/options.ts Outdated Show resolved Hide resolved
src/chain/validators.ts Outdated Show resolved Hide resolved
trumankain and others added 3 commits May 15, 2021 12:50
@trumankain @fedeci
Update src/options.ts
d1a72f6 
Removing string[] argument

Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
@trumankain
removing string array conditional for isAlphanumeric
d507040
@trumankain
reformatted with prettier
21a352b
@trumankain trumankain requested a review from fedeci May 15, 2021 21:03
fedeci
fedeci approved these changes May 16, 2021
View reviewed changes
Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing CI is unrelated, if you could run prettier also on CONTRIBUTING.md it would be great, so that we fix the failing main branch.

src/chain/validators-impl.ts Outdated Show resolved Hide resolved
@trumankain @fedeci
Update src/chain/validators-impl.ts
aeecde0 
Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
@fedeci
Copy link
Member

fedeci commented May 16, 2021

Thanks!

@fedeci fedeci merged commit 3bc2046 into express-validator:master May 16, 2021
@gustavohenke
Copy link
Member

Published in v6.12.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedeci fedeci fedeci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options support to isAlphanumeric
3 participants
@trumankain @fedeci @gustavohenke