EE 7.4.9 Trying to access array offset on value of type bool ee/legacy/libraries/Image_lib.php, line 1386

[robinsowell]

I don't have a setup to replicate, but in the code, we're doing:

       $vals = @getimagesize($path);
		
        $types = array(IMAGETYPE_GIF => 'gif', IMAGETYPE_JPEG => 'jpeg', IMAGETYPE_PNG => 'png', '18' => 'webp');
		
        $mime = (isset($types[$vals['2']])) ? 'image/' . $types[$vals['2']] : 'image/jpg';

        if ($return == true) {
            $v['width'] = $vals['0'];
            $v['height'] = $vals['1'];
            $v['image_type'] = $vals['2'];
            $v['size_str'] = $vals['3'];
            $v['mime_type'] = $mime;

            return $v;
  etc

isset($types[$vals['2']]) throws the error if getimagesize($path) is false. And fwiw, per https://www.php.net/manual/en/function.getimagesize.php

Caution
This function expects filename to be a valid image file. If a non-image file is supplied, it may be incorrectly detected as an image and the function will return successfully, but the array may contain nonsensical values.

So I'm a little iffy on defaulting to jpeg instead of just bailing out if '2' isn't set. But I'm also not sure that a valid image couldn't do that, so leaving that for another day.

But we either need to bail with feedback when getimagesize($path); is false or have a default set of $v we can return, which seems problematic.