Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing extended: true for urlencoded parser to be W3C JSON forms #72

Closed
dougwilson opened this issue Dec 18, 2014 · 8 comments

Comments

@dougwilson
Copy link
Contributor

Working draft: http://www.w3.org/TR/html-json-forms/
Thoughts from qs: ljharb/qs#63

This support may not even be called extended: true within the urlencoded parser; it may move to be an option of the JSON parser.

@dougwilson dougwilson changed the title Consider changing extended: true for json parser to be W3C JSON forms Consider changing extended: true for urlencoded parser to be W3C JSON forms Dec 18, 2014
@Fishrock123
Copy link
Contributor

If it's JSON, I think it should be the json parser?

@dougwilson
Copy link
Contributor Author

If it's JSON, I think it should be the json parser?

Probably. See the description of the issue :)

@dougwilson
Copy link
Contributor Author

Since qs will not be going this direction, we will be creating a new module and switching to that with 2.0

@jonathanong
Copy link
Member

Since qs will not be going this direction, we will be creating a new module and switching to that with 2.0

👍

@LinusU
Copy link
Member

LinusU commented Aug 3, 2015

With the release of 1.0 of multer we switched to be W3C JSON forms compatible. The logic is contained in a separate module called append-field which is an implementation of the algorithm described in the spec, with tests to see that it works as well.

Note that this is not a querystring parser per se, but it would be extremely easy to write one on top of that. If you want one I'll write it for you 👍

@LinusU
Copy link
Member

LinusU commented Aug 3, 2015

It's also very easy to write it so that it operates on a stream instead of a buffer which I think would be an advantage. That's how it works in multer, hence the api is appendField(store, key, val) which is meant to be called once for every key-value pair.

@MarkHerhold
Copy link

qs is discussing the future of the module here: ljharb/qs#140

TL;DR It seems the trend it heading to EOL qs.

@jonchurch
Copy link
Member

The W3C html-json-forms spec was abandoned. Closing

@jonchurch jonchurch closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants