Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs on signedCookie seem to be off #32

Closed
rubenvereecken opened this issue Oct 29, 2016 · 1 comment
Closed

Docs on signedCookie seem to be off #32

rubenvereecken opened this issue Oct 29, 2016 · 1 comment
Assignees
@dougwilson
Labels
docs

Comments

@rubenvereecken
Copy link

cookieParser.signedCookie(str, secret)

Parse a cookie value as a signed cookie. This will return the parsed unsigned value if it was a signed cookie and the signature was valid, otherwise it will return the passed value.

The code reads different. If the cookie seems signed but cannot be unsigned properly, false is returned, not the original argument: https://github.com/expressjs/cookie-parser/blob/master/index.js#L149.

I'd send a PR but wanted to check first.
@dougwilson dougwilson self-assigned this Nov 8, 2016
@dougwilson dougwilson added the docs label Nov 8, 2016
@dougwilson
Copy link
Contributor

Yea, sounds like a docs issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougwilson dougwilson

Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @rubenvereecken