Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: default value for "signed" option #36

Closed
ivan7237d opened this issue Sep 20, 2015 · 5 comments
Closed

README: default value for "signed" option #36

ivan7237d opened this issue Sep 20, 2015 · 5 comments
Assignees
@dougwilson
Labels
docs

Comments

@ivan7237d
Copy link

It seems that the default value is actually true, but in the README it says false.
@dougwilson
Copy link
Contributor

As far as I know it is false. Can you point to where in the code it defaults to true?

@dougwilson
Copy link
Contributor

Oh, lol, I see it (tells you how much I look at this module :) ). I wonder where that text came from.

@dougwilson
Copy link
Contributor

Nevermind, I was looking at the "signed" option. Yes, I'm not seeing the secure issue, so please point to where it is in the code :)

@ivan7237d
Copy link
Author

Wait - I was speaking of the "signed" option, so I think the first impression was the right one )

@dougwilson
Copy link
Contributor

lol, I totally can't read, apparently :) I agree with your assessment. Feel free to even make a PR, as I wont get to it for a while.

@dougwilson dougwilson self-assigned this Sep 24, 2015
dougwilson added a commit that referenced this issue Jan 6, 2020
@dougwilson
docs: fix default value for signed option
9069a9b 
closes #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougwilson dougwilson

Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @ivan7237d