Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keys option not documented #6

Closed
ForbesLindesay opened this issue Apr 23, 2014 · 4 comments
Closed

keys option not documented #6

ForbesLindesay opened this issue Apr 23, 2014 · 4 comments
Assignees
@Fishrock123

Comments

@ForbesLindesay
Copy link

Keys are provided in the example, but not documented. It would be good to make clear what options are required to make cookie-session secure.
@jonathanong
Copy link
Member

@Fishrock123 wanna do these docs too? :D

@Fishrock123
Copy link
Contributor

I'll have a go at it, but at this point I'm not 100% sure which options are required for security here either haha.

@jonathanong
Copy link
Member

i think there's just keys/secret and trust proxy from cookies.

@Fishrock123 Fishrock123 self-assigned this Apr 24, 2014
Fishrock123 added a commit that referenced this issue Apr 28, 2014
@Fishrock123
Better docs.
6ca3d4d 
Add build and npm badges.

Cookie options were just taken from
https://github.com/jed/cookies
with the defaults replaced with ours.

Fixes #5
Also see: #6
@Fishrock123
Copy link
Contributor

I'm not sure if that commit fixes this, I think I need to fix it on my own site to also use secureProxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fishrock123 Fishrock123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanong @Fishrock123 @ForbesLindesay