Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "key" to "name". #8

Closed
Fishrock123 opened this issue Apr 28, 2014 · 4 comments
Closed

Rename "key" to "name". #8

Fishrock123 opened this issue Apr 28, 2014 · 4 comments
Assignees
@Fishrock123

Comments

@Fishrock123
Copy link
Contributor

"key" is too easily confused with "keys".

We can still set it from options.key if it exists as fallback.
@jonathanong
Copy link
Member

yeah just saw that when reading the readme. +1 haha

@Fishrock123 Fishrock123 self-assigned this Apr 28, 2014
@Fishrock123
Copy link
Contributor Author

Should we make a depreciated log message for opts.key?

@jonathanong
Copy link
Member

meh that would just be annoying. just undocument it for now. next major version we'll just remove it

@Fishrock123
Copy link
Contributor Author

Can req.sessionKey also be renamed to req.sessionName? Or is it Public api?

@Fishrock123 Fishrock123 mentioned this issue May 7, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fishrock123 Fishrock123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanong @Fishrock123