Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work if use auth #25

Closed
philxia opened this issue Jul 8, 2014 · 4 comments
Closed

does not work if use auth #25

philxia opened this issue Jul 8, 2014 · 4 comments

Comments

@philxia
Copy link

philxia commented Jul 8, 2014

The cors does not work if I use the auth as below, any idea?

var app = express();
app.use(express.basicAuth('foo', 'bar'));
app.use(cors());
<<

troygoode added a commit that referenced this issue Jul 9, 2014
@troygoode
Copy link
Member

@philxia I just committed a unit test that shows the above code working. what version of express and node.js are you using?

@philxia
Copy link
Author

philxia commented Jul 9, 2014

I am using the express 3.1.2.

@troygoode
Copy link
Member

My best recommendation at this point is to upgrade to try upgrading to express 4+, since that is what my test suite is using.

@troygoode
Copy link
Member

@philxia: Alternatively if you're able to modify the test case (or tell me how to modify it) to reproduce your issue, I'll happily reopen this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants