Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 Changes Working Doc #124

Open
jonchurch opened this issue May 7, 2020 · 3 comments
Open

v5 Changes Working Doc #124

jonchurch opened this issue May 7, 2020 · 3 comments
Labels

Comments

@jonchurch
Copy link
Member

We have a doc now to collaborate on what is changing w/ v5. It's open to edits from anyone.

It exists as a way to try and pull together the changelog, and scratch for hashing out a migration guide and an announcement. But it's first goal is to serve as a reference for folks involved in the project, so we can all get a sense of what v5 is.

@jonchurch
Copy link
Member Author

jonchurch commented May 13, 2020

I updated the above doc to organize changes based on the system they relate to

In case the above gets destroyed somehow, I have this work in markdown format in a gist (it may not be up to date compared to the google doc depending on when you view it)

@jonchurch
Copy link
Member Author

jonchurch commented May 14, 2020

@dougwilson If you get a chance can you please review the "Changes by System" section of the google document? I see already that I have made a mistake in regard to the removal of app.param as pointed out in expressjs/express#2649 (comment)

I'll review these changes compared to the diff from the latest alpha against 4.17.1 tmr, to verify that the supposed changes are accurate

@dougwilson
Copy link
Contributor

Yea, np. The app.param as a whole is still there, it's just the app.param(fn) signature that was removed -- that was the entire param middleware system; app.param(name, fn) is still valid and exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants