Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 0.8 #3

Closed
jonathanong opened this issue Feb 28, 2016 · 6 comments
Closed

node 0.8 #3

jonathanong opened this issue Feb 28, 2016 · 6 comments
Assignees

Comments

@jonathanong
Copy link
Member

we still supporting this @dougwilson? https://github.com/pillarjs/resolve-path is starting to fail on 0.8. i think we can ditch it now...

@dougwilson
Copy link
Contributor

We absolutely are. The Travis CI needs to be fixed. May have wanted to ask before breaking the build (or looking at the other repositories).

@jonathanong
Copy link
Member Author

alright. let me know how to proceed. i could fix this on travis but not sure how this would differ on appveyor

@dougwilson
Copy link
Contributor

Also, why was the version bumped patch instead of minor? The dependency update is providing a new feature, which is directly visible in that module's interface, so it should be a minor version bump to represent that there is a new feature available.

@dougwilson
Copy link
Contributor

Ignoring the questionable adherence to semver on what was published, it should at least be reasonable to wait for all-green the the CIs on the commit that is going to be published before publishing. I'm rebasing your changes on my commits from earlier this year that resolves the CI configurations for the istanbul module misbehaving.

@dougwilson dougwilson self-assigned this Feb 28, 2016
@dougwilson
Copy link
Contributor

Builds should be resolved in resolve-path now.

@dougwilson
Copy link
Contributor

Oh, and I guess on the Node.js 0.8 topic over-all, yes, Node.js 0.8 can be removed from the testing, but the module will need to undergo a major version bump at the same time to be fair to the users who are depending on the modules working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants