Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interference between server.close and worker.disconnect #10

Open
Offirmo opened this issue Sep 27, 2014 · 1 comment · May be fixed by #12
Open

interference between server.close and worker.disconnect #10

Offirmo opened this issue Sep 27, 2014 · 1 comment · May be fixed by #12

Comments

@Offirmo
Copy link

Offirmo commented Sep 27, 2014

According to node documentation, calling worker.disconnect() will close existing servers. And that's true (tested it) Calling worker.disconnect()will even throw an uncaught if the servers are already closed (tested it also).

So the shutdown routine must be rewritten so that if in a worker, the midleware should only call worker.disconnect() and not close the server directly.

PR pending.

@Offirmo
Copy link
Author

Offirmo commented Oct 9, 2014

Note : my fork https://github.com/Offirmo/domain-middleware has this issue solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant