Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closing the server when not in cluster #6

Open
Offirmo opened this issue Sep 26, 2014 · 2 comments
Open

closing the server when not in cluster #6

Offirmo opened this issue Sep 26, 2014 · 2 comments

Comments

@Offirmo
Copy link

Offirmo commented Sep 26, 2014

For what I can see in the code, the current code won't attempt to close the server when not in a cluster.

This is questionable (though I can think of some debatable reasons)

Being in an undefined state should call for an immediate stop to serving potentially wrong requests.
@Offirmo
Copy link
Author

Offirmo commented Sep 26, 2014

PR pending.

@Offirmo Offirmo mentioned this issue Sep 26, 2014
Open
@Offirmo
Copy link
Author

Offirmo commented Oct 9, 2014

Note : my fork https://github.com/Offirmo/domain-middleware has this issue solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Offirmo