Problem with generator and less

[daver182]

Hi, I have found a problem when I run the Express command with the --css less option, in the app.js:

app.use(require('less-middleware')({ src: path.join(__dirname, 'public') }));

It should be (options is an object):

app.use(require('less-middleware')(path.join(__dirname, 'public'), {options}));

Because the middleware take the first parameter as the source, and the second as the object with the options. I know because I got an error with path.js, and it was because the source wasn't a string.

[jonathanong]

looks fine to me https://github.com/emberfeather/less.js-middleware

[daver182]

Yes but in the new version, 2.0 in beta state, the constructor it will change, and that problem will happen because with npm install, you get the 2.0 version not the 0.1. So it will fail eventually.

[defunctzombie]

In the new generator code I am pinning module versions to avoid this. It will not be a problem going forward.

[jonathanong]

wait i don't see any pending changes for v2. we should pin it to 1.x.x anyways.

[daver182]

Im talking about version 0.2.0-beta, https://github.com/emberfeather/less.js-middleware/blob/rewrite/readme.md

[jonathanong]

that's not even out yet, so i'm not sure what the problem is. changing it now would break new apps.

once it's out, we can update the API and pin to 0.2.0.

[defunctzombie]

I think the issue is that they published it to npm as the latest tag and the old generator had * as the dependency version and thus it now breaks for people trying to use it.

[jonathanong]

ah ok. we just need a release then

[defunctzombie]

Latest express-generator package fixes this by pinning the version better